Help with synchronized threads

[brasta78]

Hello,

Please help find my mistake - I have one thread, that starts location listener and other thread runTh(), which starts and waiting coordinates. My thread runTh() does not continue working, when locationUpdated() gets coordinates:

..
 // Start querying GPS data :
            new Thread() {

                public void run() {
                    locationProvider.setLocationListener(TrackMe.this, sec, -1, -1);
                    busy = true;
                }
            }.start();
            runTh();
....
....
 public void runTh(){
        new Thread() {
                public void run() {
                    synchronized (this) {
                       if(busy) {
                            try {
                                gps2.setText("Thread waiting");
                                wait();
                                //do something
                            } catch (InterruptedException ex) {
                                ex.printStackTrace();
                            }
                        }
                    }                          
                }
            }.start();
    }
...
...
public synchronized void locationUpdated(LocationProvider provider, Location location) {
        if (location != null && location.isValid()) {
            statusDisplay.setText("Available\n");
            QualifiedCoordinates qc = location.getQualifiedCoordinates();
            gps = gps
                    + "Lat: " + qc.getLatitude() + "\n"
                    + "Lon: " + qc.getLongitude() + "\n";
            busy = false;
            notify();
  }
}
...

[grahamhughes]

If you're using LocationListener, you don't usually need to create any threads. Just get rid completely of the two threads you have. If the processing you want to do when you get GPS coordinates is quick, then do it in the event method. If it will take time, then start a new thread to do the processing in the event handler.

Graham.

[brasta78]

I gave not exact my code, actually I have LocationListener in other package than runTh() method. So I want to start LocationListener and start runTh(), which must wait GPS coordinates and than open http connection and pass some information. I don't want to loop while(busy) in runTh() method also I need the way to terminate runTh() in wait() mode. Thats because I decided to do it with synchronized threads.

[grahamhughes]

You're having problems because you're trying to solve the wrong problem. Instead of starting a thread, then making it wait until an event occurs, simply start the thread from the event!

..
    // don't need any threads here!
    locationProvider.setLocationListener(TrackMe.this, sec, -1, -1);
....
....
 public void runTh(){
        new Thread() {
                public void run() {
                    //do something
                }
            }.start();
    }
...
...
public synchronized void locationUpdated(LocationProvider provider, Location location) {
        if (location != null && location.isValid()) {
            statusDisplay.setText("Available\n");
            QualifiedCoordinates qc = location.getQualifiedCoordinates();
            gps = gps
                    + "Lat: " + qc.getLatitude() + "\n"
                    + "Lon: " + qc.getLongitude() + "\n";
            runTh();
  }
}
...