InputStream, where is the bug?

[khua]

Hi,
This is the method that has problem(s), but i can't find.
The problem :
at first call of method it returns all chars in file, but at second and later calls it returns "".

public final String getchars() throws IOException {
        InputStream is=Resources.utf8file;
        StringBuffer buffer = null;                
        int ch=0; 
    try {         
      if (is == null)
        throw new Exception("File Does Not Exist");   

      buffer = new StringBuffer();       
     while((ch =  is.read())>-1)
         buffer.append((char) ch) ;  
       
      if (is != null)        
        is.close();
    } catch (Exception ex) {
       ex.printStackTrace();
    }

thanks.

[avraszka]

Hi,
This is the method that has problem(s), but i can't find.
The problem :
at first call of method it returns all chars in file, but at second and later calls it returns "".

public final String getchars() throws IOException {
        InputStream is=Resources.utf8file;
        StringBuffer buffer = null;                
        int ch=0; 
    try {         
      if (is == null)
        throw new Exception("File Does Not Exist");   

      buffer = new StringBuffer();       
     while((ch =  is.read())>-1)
         buffer.append((char) ch) ;  
       
      if (is != null)        
        is.close();
    } catch (Exception ex) {
       ex.printStackTrace();
    }

thanks.

I think that you should open the input stream every call, currently you are getting it from Resources.utf8file;


-------
JavaTech
j2me software

[rrafols]

The problem could be that you're closing the stream:

In the assignment 'InputStream is=Resources.utf8file;' you're not creating a new object you're just referencing an existing one (Resources.utf8file).

After reading the chars in the while loop, you close the stream, so next time you try to read from it it will be closed.

To create a new stream from a file you should use for example:

InputStream is = getClass().getResourceAsStream(filename);

Hope that helps.