java.lang.OutOfMemoryError

[csckid]

I tried to read test-wav.wav given in audiodemo project. But I got an exception java.lang.OutOfMemoryError at the line byte[] Data = baos.toByteArray();.

How do I solve this?

 ByteArrayOutputStream baos = new ByteArrayOutputStream(1024);
..
..
 byte[] Data = baos.toByteArray();

java.lang.OutOfMemoryError
	at javax.microedition.lcdui.Display$DisplayAccessor.commandAction(+309)
	at javax.microedition.lcdui.Display$DisplayManagerImpl.commandAction(+10)
	at com.sun.midp.lcdui.DefaultEventHandler.commandEvent(+68)
	at com.sun.midp.lcdui.AutomatedEventHandler.commandEvent(+47)
	at com.sun.midp.lcdui.DefaultEventHandler$QueuedEventHandler.run(+250)

[grahamhughes]

This happens, quite simply, because you have run out of memory. ByteArrayOutputStream.toByteArray() makes a copy of all the data in the object. Therefore, the total memory you will need is likely to be at least double the size of the "test-wav.wav" file.

Graham.

[csckid]

Please tell me where to make the change.

HttpConnection c = (HttpConnection) Connector.open("http://localhost/uploads/"+filename+".wav"); 		
		byte receivedFile[]=null;
		try{
			DataInputStream response = new DataInputStream(c.openInputStream());
			receivedFile = new byte[(int) (c.getLength()) ];
			response.readFully(receivedFile);
			response.close();
			c.close();
								 
		}catch(java.lang.OutOfMemoryError e){
				System.out.println("ere "+e);									
		}

I'm getting outofmemory exception. My file size is 49MB.
Exception is thrown at this line
receivedFile = new byte[(int) (c.getLength()) ];

[Tiger79]

49MB is a little too much for a mobile app I'm afraid...
Take into account that before an app can write the data to your memory card (which can contain gigabytes of data) it will have to keep it local in it's local memory (called RAM) which is way way less... You might want to chop that data into pieces and download a piece at a time instead, and add that tou your local file...

[csckid]

What is the size of mobile RAM?
How about 250KB file, is this short enough for mobile memory?

[grahamhughes]

That depends on the device. Tell us what device (or devices) you are working with (or look at their specifications). But I think no Nokia will allow you more that 16Mb (and remember you need at least twice the size of the file in free memory).

Graham.

[csckid]

Now the file size is 164KB
But I still get Out of Memory exception

HttpConnection c = (HttpConnection) Connector.open("http://localhost/uploads/"+filename+".wav"); 		
byte receivedFile[]=null;
try{
	DataInputStream response = new DataInputStream(c.openInputStream());
	receivedFile = new byte[(int) (c.getLength()) ];
	response.readFully(receivedFile);
	response.close();
	c.close();
								 
}catch(java.lang.OutOfMemoryError e){
	System.out.println("ere "+e);									
}

Exception is thrown at this line
receivedFile = new byte[(int) (c.getLength()) ];

[Tiger79]

try to debug and see what value that c.getLength() has...

[csckid]

c.getlength() value 2033062

original file size 1986KB.
...
I have changed the code now

          filecon = (FileConnection)
	 Connector.open("file:///Card/Sounds/mynewfile.amr"); 
	if(!filecon.exists()) {
	         filecon.create();
	}
					   					
       	DataOutputStream output= filecon.openDataOutputStream();
      	int p=response.readInt();
																			
	while(p!=0){
								
	    output.writeByte((int)response.readByte());
									
	      p--;
									
	}
       output.close();
       filecon.close();

I ran the file in mobile and got an EOFexception. If I change this line to
p!=-1
Still EOfexception remains.
What should I do?

The audio file runs properly.

[grahamhughes]

Now the file size is 164KB

original file size 1986KB

So... how big is the file...?

[csckid]

try to debug and see what value that c.getLength() has...

c.getlength() value 2033062

original file size 1986KB.

Forget about the file 164KB file
New Problem
I have changed the code now

 filecon = (FileConnection)
	 Connector.open("file:///Card/Sounds/mynewfile.amr"); 
	if(!filecon.exists()) {
	         filecon.create();
	}
					   					
       	DataOutputStream output= filecon.openDataOutputStream();
      	int p=response.readInt();
																			
	while(p!=0){
								
	    output.writeByte((int)response.readByte());
									
	      p--;
									
	}
       output.close();
       filecon.close();

I ran the file in mobile and got an EOFexception. If I change this line to
p!=-1
Still EOfexception remains.
What should I do?

The audio file runs properly.

[grahamhughes]

Do the first four bytes of the "response" stream contain the length?

[csckid]

Do the first four bytes of the "response" stream contain the length?

I don't know what you asking for.

Forgot to mention to more lines.

	HttpConnection c = (HttpConnection) Connector.open("http://uploads/abc.amr"); 
							
	DataInputStream response = new DataInputStream(c.openInputStream());
     
        fileconn= (FileConnection)
..
..

[grahamhughes]

I'm curious about this line of code:

      	int p=response.readInt();

It reads the first four bytes of the stream, and constructs an int from them. You then seem to be treating this as if it's the file length. How is the file length getting added to the start of the stream?

Graham.

[csckid]

THanks problem fixed
instead of

      	int p=response.readInt();

I changed it to this

      	int p=response.available();