QA suddenly fails due "The application modifies system files"

[CaCO3]

Several of my programs are system tools and therefore have to modify system files.

To my big surprise Nokia now re-reviewed one of those apps and decided to fail it, because it modifies system files.
See below a snipped of the review report:

Comments from the QA team:
The file was re-tested and an issue was discovered:

SUMMARY: The application modifies system files.

STEPS TO REPRODUCE:
1. Install "Rotate Lock Screen" from the Store
2. When installing, copy the debian package of the application safe so it can
be inspected
3. On the device, execute ls -l
/usr/share/themes/blanco/meegotouch/sysuid/style/sysuid.css*
4. Take a look at the contents of the debian package:

dpkg-deb --contents rotatelockscreen_1.0.1_armel.deb
ar vx rotatelockscreen_1.0.1_armel.deb
tar zvxf control.tar.gz

5. Take a look at the postinst and prerm scripts:

cat postinst
cat prerm

EXPECTED OUTCOME:
The application does not modify any Harmattan operating system files.

After step 3, on Harmattan PR1.3, you should see

-rw-r--r-- 1 root root 3418 Mar 1 13:47
/usr/share/themes/blanco/meegotouch/sysuid/style/sysuid.css

In step 5, you should not see scripts modifying Harmattan files.

ACTUAL OUTCOME:
After step 3, on Harmattan PR1.3, you see

-rw-r--r-- 1 root root 3410 Mar 1 13:47
/usr/share/themes/blanco/meegotouch/sysuid/style/sysuid.css
-rw-r--r-- 1 root root 3418 Mar 1 13:47
/usr/share/themes/blanco/meegotouch/sysuid/style/sysuid.css.bak

(the css file has been modified)

In step 5, you see

sed -i 's/ locked-orientation: "portrait";/ locked-orientation: "";/'
sysuid.css

How do I have to proceed?
Instead of failing the app, Nokia should say what I have to change.

As you can see on the links below, the apps are working all fine and almost all users are fine with them. (The ones who are not happy seem either not to understand the function of the app or do not know how to use their phone properly):
http://store.ovi.com/content/237392
http://store.ovi.com/content/236574
http://store.ovi.com/content/237387


This is not the first time Nokia changes their QA rules out of the blue and it is very frustrating!!!
This way, developers really are dis-encouraged to invest into Harmattan.

[mikkovtr]

I understand your view, but you probably understand the other view that allowing modifying arbitrary files eventually leads to problems with system updates, other similar "apps" or something else. I'm not saying that your particular "apps" cause problems, but what if there was another "app" modifying the same file?. With N900 modifying files is a common sport, but then you get to read about strangest problems in talk.maemo.org.

But quickly browsing through Harmattan documentation you should create a new theme which inherits Blanco theme and replaces the few files you have modified. I've never tried this, but according to documentation it looks that easy

[CaCO3]

With N900 modifying files is a common sport, but then you get to read about strangest problems in talk.maemo.org.

I have a N900 and also spend quite some time developing software for it, also I am quite active in the forum. I never had any issues with changed system files nor did I see many issues.

But quickly browsing through Harmattan documentation you should create a new theme which inherits Blanco theme and replaces the few files you have modified. I've never tried this, but according to documentation it looks that easy

But this only works, if I modify theme files. Some of my apps how ever modify other files.
I am sure there is a good way to do it.
I.e. if I would write a program in C which would do that, Nokia would not even be aware of it, and therefore would let it pass...

My main issue is:
Nokia suddenly changes the QA rules and fails apps without giving a solution for it.

[CaCO3]

I just had a look at http://harmattan-dev.nokia.com/docs/...ity_guide.html

There it sais this:

File system protection

As many files in the system are owned by the root user account, it means that the root user can normally modify its own files. If there is a security breach in the system and a malicious application or a malicious user gets elevated as the super user, normally they would be able to modify system files. To prevent this there are several areas in the file system that are protected against unauthorised modifications – even if the owner of the file or directory requests modifications. The only entity in the system that is able to modify protected files and directories is the installer.

So the installer clearly should have the right to modify system files.
I even could add an Aegis token, so I could modify Aegis protected files...

[mikkovtr]

My main issue is:
Nokia suddenly changes the QA rules and fails apps without giving a solution for it.

To me it looks as if they started with "almost anything goes" and then added some stricter rules later. Relating to original "How do I have to proceed?": do not modify system files, with theme files it is perfectly possible. About other features I can't tell.

[CaCO3]

...do not modify system files, with theme files it is perfectly possible. ..

Doesn’t

/usr/share/themes/blanco/meegotouch/sysuid/style/sysuid.css

look like a theme file to you?

Now they even published my app and did not even reply to my support request
What a shame!

[mikkovtr]

I meant it is possible to handle it properly by creating a new theme as described here:

http://harmattan-dev.nokia.com/docs/...lications.html

But like I said, QA is a bit random as it seems.